Use a reliable failure mechanism in test enclosure #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemercenary
force-pushed
the
fix-enclosureassert
branch
3 times, most recently
from
45bd833
to
9b7de13
Compare
`assert(false)` gets compiled out in release build unit tests, which prevents this case from properly generating a user warning. Switching `assert(false)` with the googletest macro `ASSERT_TRUE()` provides more reliability and the added benefit of debug text.
codemercenary
force-pushed
the
fix-enclosureassert
branch
from
9b7de13
to
c7d6e77
Compare
gittyupagain
pushed a commit
that referenced
this pull request
Mar 25, 2015
Use a reliable failure mechanism in test enclosure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert(false)gets compiled out in release build unit tests, which prevents this case from properly generating a user warning. Switchingassert(false)with the googletest macroASSERT_TRUE()provides more reliability and the added benefit of debug text.