Refactor Signal Relay, use NotifyOnAutowired instead #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the implementation of `autowiring::signal` without altering the usage contract. Make use of `NotifyWhenAutowired` rather than a custom signal registration table in order to evade issues that arise from indirect inheritance.
… were already filled.
codemercenary
added a commit
that referenced
this pull request
Jun 1, 2015
Refactor Signal Relay, use NotifyOnAutowired instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the Signal Relay structure and using more established facilities, the signal code becomes vastly simpler and we get proper support for autowiring signals from base classes.