Add a ThreadPool concept for CoreContext #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemercenary
force-pushed
the
feature-threadpool
branch
3 times, most recently
from
04e281d
to
5932e6b
Compare
The thread pool concept allows users to attach a lambda to the context to be executed by that context's thread pool. By default, contexts receive the thread pool of their parent, and the global context gets the default thread pool for the system. Contexts assign their thread pool to the thread pool of their parent upon initiation (not construction). Prior to initiation, contexts hold the null thread pool, which is an instance of NullPool that simply accumulates dispatchers until the parent context is initiated, shut down, or destroyed. Setting a context's thread pool will not cause the context to release its reference to the NullPool. Instead, the provided thread pool will be held until the context is started, and when this happens, all dispatchers will be transferred to the requested pool and then the requested pool will be initiated. Jobs added to a context's thread pool will not be run until the context is started.
codemercenary
force-pushed
the
feature-threadpool
branch
from
5932e6b
to
7b6b95a
Compare
|
I have 4 failing tests on Mac:
Which is every |
|
Can you print the failure messages? |
|
The appended lambdas seem to not run consistently. They tests fail because the |
|
Sure thing, thanks for the help. |
|
Lowering it to 5 should be fine. |
|
OK, I'm able to get the same failure. I'm looking into this now. |
gtremper
added a commit
that referenced
this pull request
Jun 9, 2015
Add a ThreadPool concept for CoreContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thread pool concept allows users to attach a lambda to the context to be executed by that context's thread pool. By default, contexts receive the thread pool of their parent, and the global context gets the default thread pool for the system. Contexts assign their thread pool to the thread pool of their parent upon initiation (not construction). Prior to initiation, contexts hold the null thread pool, which is an instance of NullPool that simply accumulates dispatchers until the parent context is initiated, shut down, or destroyed.
Setting a context's thread pool will not cause the context to release its reference to the NullPool. Instead, the provided thread pool will be held until the context is started, and when this happens, all dispatchers will be transferred to the requested pool and then the requested pool will be initiated.
Jobs added to a context's thread pool will not be run until the context is started.