Correct potential memory smasher in GetAll #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`std::get_temporary_buffer` does not guarantee sufficient space for allocations in the same way that `new` does. Use `new` here instead in order to ensure we do not smash memory during `GetAll`.
codemercenary
force-pushed
the
bug-getallsmasher
branch
from
efd721e
to
5fc0ec6
Compare
|
I couldn't get |
yeswalrus
force-pushed
the
bug-getallsmasher
branch
from
85fcae9
to
92379d9
Compare
|
Ran valgrind on MultiPostHocIntroductionTest, MultiDecorateTest, UnsatDecTest which call GetAll(). Doesn't report any problems for this branch. |
jdonald
added a commit
that referenced
this pull request
Jun 12, 2015
Correct potential memory smasher in GetAll
|
Thanks @jdonald ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::get_temporary_bufferdoes not guarantee sufficient space for allocations in the same way thatnewdoes. Usenewhere instead in order to ensure we do not smash memory duringGetAll.