Fix null function call #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are lots of weird shared pointers getting carried around and insufficient guards against null pointer dereferences. Clean this up and fix the defects. Add tests to prevent regressions, and ensure that `AutoCurrentPacketPusher` restores the prior packet on destruction rather than simply clearing it.
codemercenary
force-pushed
the
bug-acpnullcall
branch
from
2e0d8c4
to
6fbdc77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by issues with the
AutoCurrentPacketcontext pusher feature. There are lots of weird shared pointers getting carried around and insufficient guards against null pointer dereferences. Clean this up and fix the defects. Add tests to prevent regressions, and ensure thatAutoCurrentPacketPusherrestores the prior packet on destruction rather than simply clearing it.