Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test of multi-in with single-in decoration #734

Merged
merged 5 commits into from Sep 25, 2015
Merged

Conversation

hham
Copy link
Contributor

@hham hham commented Aug 22, 2015

This PR add a test of AutoFilter with multi-in and single-in to show that a filter with multi-in and single-in is not allowed for now.

@hham hham added the bug label Aug 22, 2015
@codemercenary
Copy link
Contributor

Thank you, @hham ! This is awesome.

@codemercenary codemercenary self-assigned this Aug 22, 2015
@codemercenary codemercenary added this to the v0.7.4 milestone Aug 22, 2015
@hham
Copy link
Contributor Author

hham commented Aug 22, 2015

Sure.

@jdonald
Copy link
Contributor

jdonald commented Sep 18, 2015

So this is still broken on clang, but somehow works with gcc?

If I instantiate [&f_called](float& out) { out = ++f_called; } before the multi-decoration, somehow the test passes.

@codemercenary
Copy link
Contributor

That is very strange indeed, a good finding too--should help me track this one down once I get some time to work on it.

@codemercenary
Copy link
Contributor

@jdonald would you mind merging this one?

@hham
Copy link
Contributor Author

hham commented Sep 25, 2015

Works fine on Unit tests on my Mac.

@jdonald
Copy link
Contributor

jdonald commented Sep 25, 2015

I double-checked that the test as originally written by Hyoung (floating-point variable and all), now passes on clang.

jdonald added a commit that referenced this pull request Sep 25, 2015
Add a test of multi-in with single-in decoration
@jdonald jdonald merged commit 54df55b into develop Sep 25, 2015
@jdonald jdonald deleted the add-multideco-test branch September 25, 2015 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants