Enhance autowiring::signal and provide strong sequentiality guarantees #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a major refactor to the internals of `autowiring::signal` to allow it to behave more predictably when clients use handlers that either invoke other signals or register/unregister other signal handlers. The newly refactored `autowiring::signal` should have the following improvements and design choices: * Make use of a lock-free dispatch queue concept to allow us to relax the constraint that all locks are released before handing controls to clients. * Introduce an image guarantee which ensures that all signal handlers registered at the time of a call are actually invoked, even if some of them are unregistered. * Improve efficiency by only taking copies of input arguments when it is absolutely necessary for concurrency reasons * If a user passes an argument as an rvalue reference or by value, move that argument into the dispatch queue rather than taking a copy--but only do so if it is necessary
codemercenary
force-pushed
the
feature-sequencedsignal
branch
7 times, most recently
from
e57d98d
to
d6b9a67
Compare
codemercenary
force-pushed
the
feature-sequencedsignal
branch
from
d6b9a67
to
01ce16b
Compare
yeswalrus
added a commit
that referenced
this pull request
Sep 30, 2015
Enhance autowiring::signal and provide strong sequentiality guarantees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a major refactor to the internals of
autowiring::signalto allow it to behave more predictably when clients use handlers that either invoke other signals or register/unregister other signal handlers. The newly refactoredautowiring::signalshould have the following improvements and design choices: