Make unit test more reliable, fix resulting failure #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, this test seems to pass on Mac, but fails on Windows. Something is screwy here. |
|
This passes on Linux, too. |
This unit test was not catching a defect on Mac/Linux because of the way that the compiler can optionally optimize out write operations that occur in the destructor. Change the test to make use of a static member instead so as to avoid this.
codemercenary
force-pushed
the
fix-awafterdestroy
branch
from
8b22099
to
7723f77
Compare
|
I still get the same error on Windows. In fact, outer(&OuterType::sig) += [this] {...} is not called on Mac and Linux because outer is already destroyed and not autowired any more. That's why this test passes on Mac and Linux. |
|
Good insight. Let me see if I can make this test more reliable. |
In this case, because the context is gone, we actually don't want the signal to be asserted. We are fine with breaking the normal requirement of `autowiring::signal` because the registration strategy is different.
veronicaz41
pushed a commit
that referenced
this pull request
Oct 22, 2015
Make unit test more reliable, fix resulting failure
|
Looks great!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unit test was not catching a defect on Mac/Linux because of the way that the compiler can optionally optimize out write operations that occur in the destructor. Change the test to make use of a static member instead so as to avoid this.