Split out atomic linked list behaviors into their own datatype #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some signal issues that are related to bugs with an atomic list behavior on Linux. Create a dedicated atomic linked list concept that allows us to build and test a reliable atomic linked list concept separate from the rest of signal.
codemercenary
force-pushed
the
feature-atomiclist
branch
6 times, most recently
from
c700193
to
a0c6f31
Compare
codemercenary
force-pushed
the
feature-atomiclist
branch
5 times, most recently
from
fd2b0b9
to
6b110a4
Compare
Side-effect is now that `callable_base` is a type we have to support for the user.
codemercenary
force-pushed
the
feature-atomiclist
branch
from
6b110a4
to
71c0bdd
Compare
This makes the test a bunch faster and highlights the race condition more effectively
codemercenary
force-pushed
the
feature-atomiclist
branch
2 times, most recently
from
550a0cc
to
9751cee
Compare
codemercenary
force-pushed
the
feature-atomiclist
branch
from
9751cee
to
91bf3d2
Compare
|
This test it's failing on all platforms, I think it is the root cause of our signal instability. Will investigate when I get home. |
codemercenary
force-pushed
the
feature-atomiclist
branch
from
c81d680
to
1e15fd8
Compare
codemercenary
force-pushed
the
feature-atomiclist
branch
from
1e15fd8
to
ad1151e
Compare
Screw it. No way to implement this without a two-word CAS. Just use a spin lock.
codemercenary
force-pushed
the
feature-atomiclist
branch
from
2938ab4
to
180112b
Compare
veronicaz41
pushed a commit
that referenced
this pull request
Oct 30, 2015
Split out atomic linked list behaviors into their own datatype
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some signal issues that are related to bugs with an atomic list behavior on Linux. Create a dedicated atomic linked list concept that allows us to build and test a reliable atomic linked list concept separate from the rest of signal.