Add Deferred(DispatchQueue*) #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -664,6 +664,39 @@ TEST_F(AutoFilterTest, DeferredDecorateOnly) { | |||
| ASSERT_EQ(105, dec->i) << "Deferred decorate-only AutoFilter did not properly attach before context termination"; | |||
| } | |||
|
|
|||
| class DQueueSharedPointer: | |||
| public DispatchQueue | |||
|
Good call, @hham. This should guard use cases in Platform. |
| @@ -13,4 +14,5 @@ class CoreThread; | |||
| class Deferred { | |||
| public: | |||
| Deferred(CoreThread* pThread) {} | |||
There was a problem hiding this comment.
You can remove this ctor completely.
| // Decorate the packet, forget about it: | ||
| auto packet = factory->NewPacket(); | ||
| packet->Decorate(ptr); | ||
| } |
There was a problem hiding this comment.
You probably want to add ASSERT_EQ(0UL, dQueueSharedPtr->callCount) at this point, so we can be assured that the filter is not called prematurely.
There was a problem hiding this comment.
This is the last thing, then I'll merge.
codemercenary
added a commit
that referenced
this pull request
Nov 3, 2015
Add Deferred(DispatchQueue*)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Deferred(DispatchQueue*) and a dedicated unit test.