Fix incorrect handling of private ctors #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where a factory new method is available on a type, we should not even be attempting to invoke that type's constructor, because the constructor may be private or might not even exist. Eliminate any instantiations of templates that attempt such invocation.
codemercenary
force-pushed
the
fix-badctorinvoke
branch
from
608d4dc
to
c4a9ae4
Compare
codemercenary
force-pushed
the
fix-badctorinvoke
branch
from
452f59f
to
6d096ee
Compare
codemercenary
force-pushed
the
fix-badctorinvoke
branch
from
6d096ee
to
81e6ea0
Compare
|
@codemercenary need to resolve conflicts |
|
Done. |
veronicaz41
pushed a commit
that referenced
this pull request
Dec 17, 2015
Fix incorrect handling of private ctors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where a factory new method is available on a type, we should not even be attempting to invoke that type's constructor, because the constructor may be private or might not even exist.
Eliminate any instantiations of templates that attempt such invocation.