Implement a try-to-dispatch concept #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for cases where consumers want to be able to retry lambdas from the dispatch queue while preserving order in single-threaded use cases.
| catch (...) { | ||
| // Failed to execute thunk, put it back | ||
| lk.lock(); | ||
| pThunk->m_pFlink = m_pHead; |
There was a problem hiding this comment.
From reading the comments in the header, I thought we are putting this thunk back to the tail of the queue?
There was a problem hiding this comment.
Negative, comment states that the item is replaced at the front of the queue on failure.
|
Interesting. What is the use case for this? |
veronicaz41
pushed a commit
that referenced
this pull request
Feb 10, 2016
Implement a try-to-dispatch concept
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for cases where consumers want to be able to retry lambdas from the dispatch queue while preserving order in single-threaded use cases.