Deprecate CoreContext thread pools
#848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This concept is hard to manage and has very unexpected behavior. Contexts should be containers used to manage a fixed set of well-defined classes; the thread pool should be used as a utility type for handling pooling operations, and the two types should not really meet. At a later time it might make sense to have `ThreadPool` inherit `CoreRunnable`, but for now it's fine to keep the interfaces unrelated.
codemercenary
force-pushed
the
dep-threadpool
branch
from
edac572
to
edb81b8
Compare
veronicaz41
pushed a commit
that referenced
this pull request
Feb 10, 2016
Deprecate `CoreContext` thread pools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This concept is hard to manage and has very unexpected behavior. Contexts should be containers used to manage a fixed set of well-defined classes; the thread pool should be used as a utility type for handling pooling operations, and the two types should not really meet.
At a later time it might make sense to have
ThreadPoolinheritCoreRunnable, but for now it's fine to keep the interfaces unrelated.