future is only supported by android64 gcc 4.9 #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- android32 gcc 4.9 does not support future
|
👍 |
|
This logic is a bit different from what we have in platform. Ideally the limitation will get fixed on Android 32-bit with gcc 5, yet the logic here would continue using boost/future for all 32-bit Android. However, I haven't confirmed that it'll get fixed, and up until recently thought the same about gcc 4.9. It's also likely that we'll switch over to the clang ndk rather than gcc 5, so we can deal with that when the time comes. |
|
Agree. In fact, I wasn't sure that gcc 5.0 on android 32bit will includes future. I will keep it in mind to fix this when the time comes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, Android32 gcc 4.9 does not support future.
This is required to upgrade android32 gcc4.8 to gcc 4.9.