Updates from standard #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMAKE_BINARY_DIR may contain spaces, ensure the install command wraps this path in quotes.
CMAKE_BINARY_DIR may contain spaces
…ple that want to call project() directly
remove set_standard_output_variables macro, replace with standard_project* functions
…LAGS. This is already handled by cmake using CMAKE_POSITION_INDEPENDENT_CODE and CMAKE_<lang>_COMPILE_OPTIONS_PIC which is set based on the compiler
Remove unnessecary sets from config version template
Fix code for setting -fPIC
Update README.md with StandardPackage description
Fix scope problem with StandardProject
yeswalrus
force-pushed
the
upd-standard
branch
from
3221019
to
9b204f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.