Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup ConfigManager #983

Merged
merged 2 commits into from Aug 19, 2016
Merged

Cleanup ConfigManager #983

merged 2 commits into from Aug 19, 2016

Commits on Aug 18, 2016

  1. Remove unimplemented function

    Walter Gray committed Aug 18, 2016
    Copy the full SHA
    6b1eb7c View commit details
    Browse the repository at this point in the history

  2. pass by const reference instead of by rvalue reference to avoid makin… 

    …g copies unnessecarily.

name is often not copied, so rvalue reference adds overhead. value is always copied, but doing so by rvalue reference makes calling the function more burdensome than it needs to be.
    Walter Gray committed Aug 18, 2016
    Copy the full SHA
    87bcc04 View commit details
    Browse the repository at this point in the history