Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special case 0 or 1? #14

Closed
jonbf opened this issue Sep 8, 2016 · 2 comments
Closed

Special case 0 or 1? #14

jonbf opened this issue Sep 8, 2016 · 2 comments
Labels

Comments

@jonbf
Copy link

jonbf commented Sep 8, 2016

The test says it's looking for:

"I am ${i} strange loop${i === 0 ? '' : 's'}."

But shouldn't it be looking for

"I am ${i} strange loop${i === 1 ? '' : 's'}."

?

@AnnJohn
Copy link
Contributor

AnnJohn commented Sep 8, 2016

hi @jonbf could you please use Ask a Question and someone will help you out right away. Thanks!

@AnnJohn AnnJohn closed this as completed Sep 8, 2016
@jonbf
Copy link
Author

jonbf commented Sep 9, 2016

For sure - I shouldn't have phrased the comment as a question -- I meant it
not for my own benefit but as a suggested diff to the curriculum. Of course
I am a n00b and the suggestion may be wrong :)

On Thu, Sep 8, 2016 at 1:34 PM, AnnJohn notifications@github.com wrote:

hi @jonbf https://github.com/jonbf could you please use Ask a Question
and someone will help you out right away. Thanks!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVA7W_1w5YaoCBFRHl4VRfY7OPOpf-urks5qoHFngaJpZM4J4SHS
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants
@AnnJohn @jonbf and others