Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme and tests to not make doWhileLoop condition redundant #60

Merged
merged 2 commits into from
Feb 1, 2019

Conversation

jd2rogers2
Copy link
Contributor

@sgharms
goes with #59

tests could've been passed before with the following (meaning without the incrementVariable() from the readme, with this being irrelevant i think some students were getting confused)

function doWhileLoop(arr){
  do {
    arr.pop();
  } while (arr.length);
  return arr;
}

@sgharms sgharms merged commit f315abd into learn-co-curriculum:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants