Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectDifferentDrivers #4

Closed
MiriamPeskowitz opened this issue Feb 19, 2020 · 1 comment
Closed

SelectDifferentDrivers #4

MiriamPeskowitz opened this issue Feb 19, 2020 · 1 comment

Comments

@MiriamPeskowitz
Copy link

This function and what it expects is really unclear. AND the tests pass if you just pass in one of the two functions (returnFirstTwoDrivers or returnLastTwoDrivers. And the suggested solution uses a function called whichDrivers, that isn't really clear, nor are the steps it would take to get there, and even the tech coach was stymied. Thanks for considering changing this for other students.
Screen Shot 2020-02-19 at 12 46 30 PM

This code passed. The tech coach had suggested just adding in one of the functions first, to see what the response would be, and that's how we figured out it passed.

if the goal is for us to use the selectingDrivers array, then you should give students more of a hint about that, or move it to just before this final function. Then you should change the solution code. And also, it would be great to see in the lab or lesson whether we can include the two functions just as an array, with brackets, as an argument (it doesn't, but showing us how to destructure here, or emphasizing the pattern of putting multiple functions into an array to pass in would be really helpful).

solution code to be changed to make things easier to understand
Screen Shot 2020-02-19 at 12 53 01 PM

screenshot of functions in bracketed array:
Screen Shot 2020-02-19 at 12 56 14 PM

@lizbur10
Copy link
Contributor

Thank you for spotting this issue and providing feedback. The lesson has been updated to clarify the requirements.

We apologize for any frustration you might have encountered during this process but thank you for helping us ensure that those who follow in your path will not encounter the same problems that you faced.

Thank you for contributing to the Flatiron School curriculum. 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants