Change final test in genre_spec.rb #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last test uses the same wording as the previous test This causes you to think your new form is failing when it is fine The issue is actually your edit form is wrong This is causing confusion for the students Update: it 'shows a new form that submits content and redirects and prints out params' To now read: it 'shows an edit form that submits content and redirects and prints out params'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final test in
genre_spec.rbuses the same wording as the previous test. The test for the new form and edit form have the same wording.it 'shows a new form that submits content and redirects and prints out params'This is a causing confusion for students as they think something is wrong with their new genre form when the issue is actually their edit genre form.
Updated the wording for the edit form test to instead read:
it 'shows an edit form that submits content and redirects and prints out params'