Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unneeded "success" route in starter code #301

Open
gd875 opened this issue Jan 12, 2017 · 0 comments
Open

Unneeded "success" route in starter code #301

gd875 opened this issue Jan 12, 2017 · 0 comments

Comments

@gd875
Copy link
Collaborator

gd875 commented Jan 12, 2017

The starter code has an unnecessary route that is not required by the tests. Upon successful login, the test expects to be redirected to the /account route, not /success.
Also, the /account route does not check to see if the user is logged in.

get "/success" do
if logged_in?
erb :success
else
redirect "/login"
end
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant