-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add licencse #142
[ENH] add licencse #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @Remi-Gau for putting this together!! \\ö//
It is great to have the human readable summary there, and link to full documents for both licenses! :)
One question: "Hitchhacker's guide to the brain (H2GB)" --> is it an accidental switch and should be HG2B? 🙃
tags: fMRI, MRI, --> add dMRI? you also said electrophysiology is already there (just not yet linked IIRC) --> maybe it would be great to either have a complete choice list of tags in a TAGs.md
file, where people can see all used ones (for max consistency) and make a PR to add a missing one which in turn can then be used by future submissions. What do you think?
Other than these little comments, I just added some missing little words and think this PR comes with great material and is ready to be merged!! 🚀 rockstar, @Remi-Gau !!! Thanks so much!
I agree that this is a nice thing to have. Apparently the Turing way got it from the Carpentries. Feels better to directly mention the Carpentries in this case, no? Or should we just link to the Turing way?
Well this is obviously a reference to Douglas Adams master piece which usually gets referred to as H2G2 because the 2 are exponents: H^2G^2 https://en.wikipedia.org/wiki/The_Hitchhiker%27s_Guide_to_the_Galaxy So I tried to use the abbreviation style.
Yes. This is unrelated to this PR, right? So will open a separate issue about that.
|
Unless I get a veto on this one I will merge it in 48 hours. |
it's all great @Remi-Gau 🚀 . Referring to the Carpentries is perfect! :) Thanks also for making a separate issue for the tags. |
Cool. Will still wait a bit: not everyone compulsively checks github notifications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally read everything, it is great, thanks a lot! <3
For curiosity, why 2 different licenses are used?
in short one for any "code" stuff and another for the "non code" part. creative commons is not ideal for code and licenses for software not ideal for actual text: not sure I can elaborate more than that, but this is the approach I have seen in several places by people who have thought more deeply than me about this |
That is enough for me to remember this information in the future :-) |
Adapted from the turing-way licensing
https://github.com/alan-turing-institute/the-turing-way/blob/master/LICENSE.md
fixes #68