Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add licencse #142

Merged
merged 2 commits into from
Jan 14, 2021
Merged

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Jan 8, 2021

@Remi-Gau Remi-Gau linked an issue Jan 8, 2021 that may be closed by this pull request
@Remi-Gau Remi-Gau changed the title [END] add licencse [ENH] add licencse Jan 8, 2021
Copy link
Member

@katjaq katjaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @Remi-Gau for putting this together!! \\ö//
It is great to have the human readable summary there, and link to full documents for both licenses! :)

One question: "Hitchhacker's guide to the brain (H2GB)" --> is it an accidental switch and should be HG2B? 🙃

tags: fMRI, MRI, --> add dMRI? you also said electrophysiology is already there (just not yet linked IIRC) --> maybe it would be great to either have a complete choice list of tags in a TAGs.md file, where people can see all used ones (for max consistency) and make a PR to add a missing one which in turn can then be used by future submissions. What do you think?

Other than these little comments, I just added some missing little words and think this PR comes with great material and is ready to be merged!! 🚀 rockstar, @Remi-Gau !!! Thanks so much!

@Remi-Gau
Copy link
Collaborator Author

Thank you so much @Remi-Gau for putting this together!! \ö//
It is great to have the human readable summary there, and link to full documents for both licenses! :)

I agree that this is a nice thing to have. Apparently the Turing way got it from the Carpentries. Feels better to directly mention the Carpentries in this case, no? Or should we just link to the Turing way?

One question: "Hitchhacker's guide to the brain (H2GB)" --> is it an accidental switch and should be HG2B? upside_down_face

Well this is obviously a reference to Douglas Adams master piece which usually gets referred to as H2G2 because the 2 are exponents: H^2G^2

https://en.wikipedia.org/wiki/The_Hitchhiker%27s_Guide_to_the_Galaxy

So I tried to use the abbreviation style.

tags: fMRI, MRI, --> add dMRI? you also said electrophysiology is already there (just not yet linked IIRC) --> maybe it would be great to either have a complete choice list of tags in a TAGs.md file, where people can see all used ones (for max consistency) and make a PR to add a missing one which in turn can then be used by future submissions. What do you think?

Yes. This is unrelated to this PR, right? So will open a separate issue about that.

Other than these little comments, I just added some missing little words and think this PR comes with great material and is ready to be merged!! rocket rockstar, @Remi-Gau !!! Thanks so much!

@Remi-Gau Remi-Gau mentioned this pull request Jan 11, 2021
@Remi-Gau
Copy link
Collaborator Author

Unless I get a veto on this one I will merge it in 48 hours.

@katjaq
Copy link
Member

katjaq commented Jan 11, 2021

it's all great @Remi-Gau 🚀 . Referring to the Carpentries is perfect! :) Thanks also for making a separate issue for the tags.
Please feel free to go ahead and merge. I saw @alexandreroutier also gave thumbs up 🙂

@Remi-Gau
Copy link
Collaborator Author

Cool. Will still wait a bit: not everyone compulsively checks github notifications.

Copy link
Collaborator

@alexandreroutier alexandreroutier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally read everything, it is great, thanks a lot! <3

For curiosity, why 2 different licenses are used?

@Remi-Gau
Copy link
Collaborator Author

For curiosity, why 2 different licenses are used?

in short

one for any "code" stuff and another for the "non code" part.

creative commons is not ideal for code and licenses for software not ideal for actual text: not sure I can elaborate more than that, but this is the approach I have seen in several places by people who have thought more deeply than me about this

@alexandreroutier
Copy link
Collaborator

creative commons is not ideal for code and licenses for software not ideal for actual text: not sure I can elaborate more than that, but this is the approach I have seen in several places by people who have thought more deeply than me about this

That is enough for me to remember this information in the future :-)

@Remi-Gau Remi-Gau merged commit cc3fc42 into learn-neuroimaging:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a licence
3 participants