Fixed model.remove ignoring callback #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know if this behavior was intended, but it's wrong. If I call .remove on the same model twice for whatever reason, second call will never execute callback, which will break execution flow.
| @@ -661,9 +661,7 @@ Model.prototype._where = function _where (where) { | |||
| */ | |||
|
|
|||
| Model.prototype.remove = function remove (fn) { | |||
| if (this._removing) return this; | |||
There was a problem hiding this comment.
good catch. there's no reason to remove the same document twice but we definitely need to execute the callback.
we should keep the promise and just add the fn to it.
promise.addBack(fn)
just call Promise.addBack with new callback. No need to actually remove model twice.
|
Yes, calling addBack with new callback seems more sensible behavior. I've changed patch. |
aheckmann
added a commit
that referenced
this pull request
Nov 14, 2012
Fixed model.remove ignoring callback
|
merged! thanks |
aheckmann
added a commit
that referenced
this pull request
Nov 14, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this behavior was intended, but it's wrong.
If I call .remove on the same model twice for whatever reason, second call will never execute callback, which will break execution flow.