-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support torch.bfloat16 in hivemind.compression #524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borzunov
force-pushed
the
fix-compressing-bfloat16
branch
from
November 28, 2022 04:52
cc140c9
to
e4c9f83
Compare
justheuristic
approved these changes
Nov 28, 2022
borzunov
changed the title
Fix CompressionType.NONE processing torch.bfloat16
Support torch.bfloat16 in hivemind.compression
Nov 28, 2022
justheuristic
approved these changes
Nov 28, 2022
borzunov
force-pushed
the
fix-compressing-bfloat16
branch
from
November 28, 2022 06:13
f5bdc10
to
fabbd2e
Compare
borzunov
force-pushed
the
fix-compressing-bfloat16
branch
from
November 28, 2022 06:26
fabbd2e
to
c1438e1
Compare
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
==========================================
+ Coverage 75.89% 76.01% +0.12%
==========================================
Files 81 81
Lines 7947 7960 +13
==========================================
+ Hits 6031 6051 +20
+ Misses 1916 1909 -7
|
mryab
pushed a commit
that referenced
this pull request
Nov 29, 2022
This PR implements bfloat16 support for `CompressionType.NONE` and `CompressionType.BLOCKWISE_8BIT`. This is important for the Petals client, see bigscience-workshop/petals#79 (cherry picked from commit 1e4af43)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements bfloat16 support for
CompressionType.NONE
andCompressionType.BLOCKWISE_8BIT
.This is important for the Petals client, see bigscience-workshop/petals#79