Remove direct coroutine call #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
==========================================
+ Coverage 75.92% 76.04% +0.12%
==========================================
Files 81 81
Lines 7995 7995
==========================================
+ Hits 6070 6080 +10
+ Misses 1925 1915 -10
|
mryab
approved these changes
Mar 11, 2023
There was a problem hiding this comment.
LGTM, @justheuristic do you see any downsides to this? The docs for asyncio.wait_for mention automatic conversion of coroutines to tasks — perhaps it means that this change is safe
mryab
pushed a commit
that referenced
this pull request
Mar 31, 2023
Python 3.11 forbids direct calls to coroutines. (cherry picked from commit 351abc5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.11 forbids direct calls to coroutines.