Use separate binaries for all supported OS and architectures #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borzunov
force-pushed
the
separate-binaries
branch
from
3ed013c
to
0e351c7
Compare
borzunov
commented
Aug 31, 2023
| "p2pd-darwin-amd64": "a9e5fee6bdcbfb5cc7f1a9b19e3fa4c91ceb18108b20472bf7affa62c590a964", | ||
| "p2pd-darwin-arm64": "5868f2000f4d0746c5349f3480cb5450f66d4391570b420a8f888afc9e9152af", | ||
| "p2pd-linux-amd64": "a9d456006e915d3cbbc8e5e9902d5b1a3120235f317e113137d6b631e2c810ac", | ||
| "p2pd-linux-arm64": "b03c02e6afa47f158183f6267eecf4adb0e17120d534402c99dc33f3a2915cb1", |
There was a problem hiding this comment.
Copied from https://github.com/learning-at-home/go-libp2p-daemon/releases/tag/v0.3.18 (now hashes are computed in CI automatically)
Codecov Report
@@ Coverage Diff @@
## master #588 +/- ##
==========================================
+ Coverage 85.32% 85.40% +0.07%
==========================================
Files 81 81
Lines 8009 8009
==========================================
+ Hits 6834 6840 +6
+ Misses 1175 1169 -6 |
mryab
approved these changes
Aug 31, 2023
borzunov
changed the title
mryab
pushed a commit
that referenced
this pull request
Aug 31, 2023
This PR uses makes hivemind use a separate p2pd binary for each `(os, platform)`, so: - Now we download 2x smaller binary for a specific macOS arch, instead of downloading the large universal binary - Now we also provide `p2pd-linux-arm64` binary (maybe someone wants to run a DHT node on Raspberry Pi?) (cherry picked from commit 27318f9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses makes hivemind use a separate p2pd binary for each
(os, platform), so:p2pd-linux-arm64binary (maybe someone wants to run a DHT node on Raspberry Pi?)