Consider multiple CPU arch aliases #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mryab
approved these changes
Aug 31, 2023
Codecov Report
@@ Coverage Diff @@
## master #590 +/- ##
==========================================
+ Coverage 85.19% 85.44% +0.24%
==========================================
Files 81 81
Lines 8009 8009
==========================================
+ Hits 6823 6843 +20
+ Misses 1186 1166 -20 |
mryab
pushed a commit
that referenced
this pull request
Aug 31, 2023
(cherry picked from commit 64f1f1e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crucial things here is to map
aarch64toarm64(the same CPU is arm64 on macOS and aarch64 on Linux). However, I've added a few other aliases to be sure :)