Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump p2pd version #598

Merged
merged 12 commits into from
Dec 4, 2023
Merged

Bump p2pd version #598

merged 12 commits into from
Dec 4, 2023

Conversation

dvmazur
Copy link
Collaborator

@dvmazur dvmazur commented Nov 21, 2023

No description provided.

@justheuristic
Copy link
Member

Note: we had to fork py-multiaddr because the previous version required py-cid that caused a dependency conflict

justheuristic
justheuristic approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@justheuristic justheuristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justheuristic
Copy link
Member

The only caveat is that if one person runs 2+ servers on one machine with the same identity file AND at least one of them is old version and at least one is new, THEN the duplicate check may not catch this.

I've asked @borzunov and @mryab on their opinion. If they approve, let's merge this

mryab
mryab reviewed Dec 2, 2023
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
mryab
mryab reviewed Dec 2, 2023
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Dec 2, 2023 •
edited
Loading

Codecov Report

Merging #598 (88b6f32) into master (06e979b) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
+ Coverage   85.31%   85.41%   +0.09%     
==========================================
  Files          81       81              
  Lines        8021     8006      -15     
==========================================
- Hits         6843     6838       -5     
+ Misses       1178     1168      -10
Files Coverage Δ
hivemind/p2p/p2p_daemon_bindings/datastructures.py 75.72% <100.00%> (+0.30%) ⬆️

... and 5 files with indirect coverage changes

@dvmazur dvmazur merged commit d20e810 into master Dec 4, 2023
15 checks passed
@dvmazur dvmazur deleted the bump-p2pd branch December 4, 2023 14:09
jmikedupont2 pushed a commit to meta-introspector/hivemind that referenced this pull request Mar 29, 2024
@dvmazur
Bump p2pd version and remove pymultihash (learning-at-home#598)
c5cf121 
* Bump p2pd version
* Bump multiaddr
* Remove pymultihash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mryab mryab mryab left review comments

@justheuristic justheuristic justheuristic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dvmazur @justheuristic @mryab