added symfony var_dumper in order to make sure Dump test passes

learning-student · Apr 13, 2019 · fae1fb9 · fae1fb9
1 parent a1bd588
commit fae1fb9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/composer.json b/composer.json
@@ -35,7 +35,8 @@
     "php-coveralls/php-coveralls": "^2.1",
     "mockery/mockery": "~1.0",
     "codedungeon/phpunit-result-printer": "^0.14.0",
-    "php-mock/php-mock": "^2.0"
+    "php-mock/php-mock": "^2.0",
+    "symfony/var-dumper": "^4.2"
   },
   "autoload": {
     "files": [

diff --git a/src/Helpers/Dump.php b/src/Helpers/Dump.php
@@ -6,7 +6,7 @@
 use Symfony\Component\VarDumper\Dumper\HtmlDumper;
 use Symfony\Component\VarDumper\Cloner\VarCloner;
 
-class Dump
+final class Dump
 {
 
     /**

diff --git a/src/Helpers/FW.php b/src/Helpers/FW.php
@@ -67,8 +67,10 @@ public static function current(): string
      *
      * @return string
      */
-    public static function version(string $expression = self::VERSION_WITHOUT_BUG_FIX): string
+    public static function version(string $expression = null): string
     {
+        $expression = $expression ?? self::VERSION_WITHOUT_BUG_FIX;
+
         if (static::is(static::LARAVEL)) {
             return static::extractVersion(constant('Illuminate\Foundation\Application::VERSION'), $expression);
         }