Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move_table_issue #4

Open
Hanziscool opened this issue Aug 20, 2021 · 1 comment
Open

move_table_issue #4

Hanziscool opened this issue Aug 20, 2021 · 1 comment
Assignees
@Hanziscool
Labels
enhancement New feature or request
Milestone
complete_script_n...

Comments

@Hanziscool
Copy link

Moving the Bins

  1. we can move the bins closer to the robot.
  2. if we move the bins will any calculations fail?
  3. we could use a new branch for this check... this is important because if the objects falls to the floor we will never be able to pick it up
@Hanziscool Hanziscool self-assigned this Aug 20, 2021
@Hanziscool Hanziscool added the enhancement New feature or request label Aug 20, 2021
@Hanziscool
Copy link
Author

Screenshot 2021-08-20 at 10 43 06 AM

rojas70 pushed a commit that referenced this issue Oct 11, 2021
@HansenCugito @rojas70
# This is a combination of 4 commits.
551459c 
# This is the 1st commit message:

Fix fallen objs

In Picking.return_fallen_objs():
- Refactor for loop into list comp
- Tackle base case wehen we load 1 obj and the boject fell. We will return empty goal obj name, origin pos, unit quat, exactly like what we did in Picking.get_goal_object()
- Turn on fallen obj flag inside return_fallen_objs() function if all objects has fallen
In picking.py
- Rename self.fallen_objs_flag to self.all_objs_fallen_flag
In Picking._reset_internal:
- If fallen objs flag is on, copy obj names, not yet cons obj names from fallen objs back to obj names
- Proceed to clear fallen objs
- Turn off flag
In Picking.step()
- Update fallen obj flag name

# This is the commit message #2:

merge

# This is the commit message #3:

accepted merge changes

# This is the commit message #4:

Fix fallen objs, comment fallen objs
@rojas70 rojas70 added this to the complete_script_no_her milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hanziscool Hanziscool

Labels
enhancement New feature or request
Projects
None yet
Milestone
complete_script_no_her
Development

No branches or pull requests
2 participants
@rojas70 @Hanziscool