fix build error from rollup-plugin-img and add additional img source prop to rounded card component #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
π Relevant Jira Issues
Fixes react learncard build failing by providing output path to the rollup-plugin-img plugin for images larger than 8KB.
Not sure if the images will load given the import in the react component, but I added an additional prop to take for the component so if it doesn't work I can just add the images to the learncardapp repo and pass them into the component that way.
Seems there is an open issue on the plugin's github: alwaysonlinetxm/rollup-plugin-img#3
Someone put up a PR related to it but there's been no activity on it for quite awhile.
π What is the context and goal of this PR?
π₯΄ TL; RL:
π‘ Feature Breakdown (screenshots & videos encouraged!)
π Important tradeoffs made:
π Types of Changes
π³ Does This Create Any New Technical Debt? ( If yes, please describe and add JIRA TODOs )
Testing
π¬ How Can Someone QA This?
π± π₯ Which devices would you like help testing on?
π§ͺ Code Coverage
Documentation
π Gitbook
π Storybook
β PR Checklist
π Ready to squash-and-merge?: