Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build error from rollup-plugin-img and add additional img source prop to rounded card component #69

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

goblincore
Copy link
Collaborator

@goblincore goblincore commented Aug 26, 2022

Overview

🎟 Relevant Jira Issues

Fixes react learncard build failing by providing output path to the rollup-plugin-img plugin for images larger than 8KB.
Not sure if the images will load given the import in the react component, but I added an additional prop to take for the component so if it doesn't work I can just add the images to the learncardapp repo and pass them into the component that way.

Seems there is an open issue on the plugin's github: alwaysonlinetxm/rollup-plugin-img#3
Someone put up a PR related to it but there's been no activity on it for quite awhile.

πŸ“š What is the context and goal of this PR?

πŸ₯΄ TL; RL:

πŸ’‘ Feature Breakdown (screenshots & videos encouraged!)

πŸ›  Important tradeoffs made:

πŸ” Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (refactor, documentation update, etc)

πŸ’³ Does This Create Any New Technical Debt? ( If yes, please describe and add JIRA TODOs )

  • No
  • Yes

Testing

πŸ”¬ How Can Someone QA This?

πŸ“± πŸ–₯ Which devices would you like help testing on?

πŸ§ͺ Code Coverage

Documentation

πŸ“œ Gitbook

πŸ“Š Storybook

βœ… PR Checklist

  • Related to a Jira issue (create one if not)
  • My code follows style guidelines (eslint / prettier)
  • I have manually tested common end-2-end cases
  • I have reviewed my code
  • I have commented my code, particularly where ambiguous
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to gitbook documentation

πŸš€ Ready to squash-and-merge?:

  • Code is backwards compatible
  • There is not a "Do Not Merge" label on this PR
  • I have thoughtfully considered the security implications of this change.
  • This change does not expose new public facing endpoints that do not have authentication

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2022

πŸ¦‹ Changeset detected

Latest commit: 2665b06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@learncard/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@goblincore goblincore requested a review from a team August 26, 2022 03:42
@goblincore goblincore merged commit a5ca571 into main Aug 26, 2022
@goblincore goblincore deleted the fix-build-error branch August 26, 2022 04:13
@github-actions github-actions bot mentioned this pull request Aug 26, 2022
Custard7 pushed a commit that referenced this pull request Oct 31, 2022
…prop to rounded card component (#69)

* add output path option for rollup plugin img

* Create heavy-socks-fold.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants