Can't start KA Lite server if port 8008 is occupied #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@radinamatic use this windows installer to test this PR, I have new fixes in hardcoded KALITE_HOME path environment variable. |
|
@mrpau-richard I've tested the latest installer, occupied port alert is in place and I can see the environment variables, but no
Let me know if there's anything else I can check! |
|
@radinamatic I think it's fine even if the KALITE_HOME is not set because it's automatically default to |
|
Great work, let's get it merged and I'll remember to add a release note about it in KA Lite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I created a notification to notify the user if port 8008 is occupied.
Issues addressed
This fixes #131
@radinamatic can you test this PR using this windows installer
To test it, Run the command
python -m SimpleHTTPServer 8008in the command prompt before starting the KA Lite server.It will show a notification when starting KA Lite and the port 8008 is occupied.
