New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't start KA Lite server if port 8008 is occupied #454

Merged
merged 2 commits into from Jun 8, 2017

Conversation

Projects
None yet
3 participants
@mrpau-richard
Member

mrpau-richard commented May 24, 2017

Summary

I created a notification to notify the user if port 8008 is occupied.

Issues addressed

This fixes #131

@radinamatic can you test this PR using this windows installer

To test it, Run the command python -m SimpleHTTPServer 8008 in the command prompt before starting the KA Lite server.

It will show a notification when starting KA Lite and the port 8008 is occupied.
src7

@mrpau-richard mrpau-richard requested a review from radinamatic May 24, 2017

@mrpau-richard

This comment has been minimized.

Show comment
Hide comment
@mrpau-richard

mrpau-richard May 30, 2017

Member

@radinamatic use this windows installer to test this PR, I have new fixes in hardcoded KALITE_HOME path environment variable.

Member

mrpau-richard commented May 30, 2017

@radinamatic use this windows installer to test this PR, I have new fixes in hardcoded KALITE_HOME path environment variable.

@radinamatic

This comment has been minimized.

Show comment
Hide comment
@radinamatic

radinamatic Jun 7, 2017

Contributor

@mrpau-richard I've tested the latest installer, occupied port alert is in place and I can see the

KALITE_PYTHON=\Python27\python.exe
KALITE_SCRIPT_DIR=\Python27\Scripts

environment variables, but no KALITE_HOME.

msedge_-_win10_kalite_home

Let me know if there's anything else I can check!

Contributor

radinamatic commented Jun 7, 2017

@mrpau-richard I've tested the latest installer, occupied port alert is in place and I can see the

KALITE_PYTHON=\Python27\python.exe
KALITE_SCRIPT_DIR=\Python27\Scripts

environment variables, but no KALITE_HOME.

msedge_-_win10_kalite_home

Let me know if there's anything else I can check!

@mrpau-richard

This comment has been minimized.

Show comment
Hide comment
@mrpau-richard

mrpau-richard Jun 8, 2017

Member

@radinamatic I think it's fine even if the KALITE_HOME is not set because it's automatically default to user/.kalite path. @mrpau-eduard I think you can merge this PR.

Member

mrpau-richard commented Jun 8, 2017

@radinamatic I think it's fine even if the KALITE_HOME is not set because it's automatically default to user/.kalite path. @mrpau-eduard I think you can merge this PR.

@mrpau-eduard mrpau-eduard self-requested a review Jun 8, 2017

@benjaoming benjaoming merged commit 108fbfb into learningequality:master Jun 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jun 8, 2017

Member

Great work, let's get it merged and I'll remember to add a release note about it in KA Lite.

Member

benjaoming commented Jun 8, 2017

Great work, let's get it merged and I'll remember to add a release note about it in KA Lite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment