Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setTimeout from useKWindowDimensions and useKResponsiveWindow test files #480

Closed
MisRob opened this issue Oct 26, 2023 · 6 comments
Closed
Assignees
Labels
Component: useKResponsiveWindow help wanted Open source contributors welcome P2 - normal Priority: Nice to have

Comments

@MisRob
Copy link
Member

MisRob commented Oct 26, 2023

  • Remove setTimeout from useKWindowDimensions and useKResponsiveWindow test files (introduced here and here)
  • Keep the tests but use a more reliable timing technique instead of using setTimeout which may cause the following problems:

    flagging that using setTimeout in these tests like this could make them flaky - there's no guarantee that the content of the setTimeout will execute before the test itself is torn down, or that failures will even be registered (by @rtibbles)

@MisRob
Copy link
Member Author

MisRob commented Oct 26, 2023

@rtibbles suggests using $nextTick

@MisRob MisRob added the help wanted Open source contributors welcome label Oct 26, 2023
@MisRob MisRob mentioned this issue Oct 26, 2023
8 tasks
@nucleogenesis nucleogenesis added the P2 - normal Priority: Nice to have label Oct 31, 2023
@Soren568
Copy link
Contributor

Hi, I would like to work on this. Could you assign it to me?

@MisRob
Copy link
Member Author

MisRob commented Nov 22, 2023

Hi @Soren568, yes, thank you!

@Soren568
Copy link
Contributor

@MisRob I initiated the PR above, this is my first PR for kolibri so please let me know if there is anything I missed.

@MisRob
Copy link
Member Author

MisRob commented Nov 24, 2023

Thank you, @Soren568

@MisRob
Copy link
Member Author

MisRob commented Dec 7, 2023

Closed by #491

@MisRob MisRob closed this as completed Dec 7, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: useKResponsiveWindow help wanted Open source contributors welcome P2 - normal Priority: Nice to have
Projects
None yet
Development

No branches or pull requests

3 participants