Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Readme #482

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Updated Readme #482

merged 3 commits into from
Oct 31, 2023

Conversation

BabyElias
Copy link
Contributor

Description

Updated develop branch to main branch in readme, along with respective links.

Issue addressed

Issue #479

Changelog

  • #482
  • Description: Changed develop branch to main branch in Readme
  • Products impact: Script Enhancement
  • Addresses: Broken "develop" branch link #479
  • Components: none
  • Breaking: no
  • Impacts a11y: no
  • Guidance: -

@MisRob MisRob self-requested a review October 27, 2023 09:25
@BabyElias
Copy link
Contributor Author

@MisRob Can you please review this PR?

@BabyElias
Copy link
Contributor Author

@MisRob Are there any changes required?

@MisRob
Copy link
Member

MisRob commented Oct 30, 2023

Thank you for your contribution, @BabyElias.

Please allow us several days for responses and reviews, we have a queue of many pull requests in more than one product. It's good to remind yourself if we don't get in touch in a week or so, however that happens pretty rarely.

Best wishes

@BabyElias
Copy link
Contributor Author

Okay, Thank you!

CHANGELOG.md Outdated
@@ -18,6 +18,17 @@ Changelog is rather internal in nature. See release notes for the public overvie

[#478]: https://github.com/learningequality/kolibri-design-system/pull/478

- [#482]
- **Description:** Changed develop branch to main branch in Readme
- **Products impact:** Script Enhancement
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update this to "-" before merging since this is internal to Kolibri Design System and will have not impact on products (Kolibri, Studio)

@MisRob
Copy link
Member

MisRob commented Oct 31, 2023

All good, thanks @BabyElias

from the changelog.

Changelog items updated are KDS internal
and have no impact on products.
@MisRob MisRob merged commit 3edce32 into learningequality:main Oct 31, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants