-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance tasks #558
Maintenance tasks #558
Conversation
- Move all composables to lib/composables - Indicate private composables by "_" prefix - Remove deprecated KResponsiveWindow mixin documentation page in favor of a new useKResponsiveWindow page
These are installed together with KDS in products so this ensure we know exactly what versions are used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense to me thanks Misha!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look correct to me. Thanks @MisRob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The only question that would come to mind would be. Why does the useKDimensions have to be private? It seems to me that it could be useful in some contexts if you want to watch the windows height and width.
In the context of this PR, it's private because it was private before, it just wasn't indicated in its name. You're right it could be useful. If it's needed in the products, we can prepare a documentation page for it and make it public. |
Description
A collection of maintenance tasks. See commit messages or changelog items below. Composables location clean up was discussed in the meeting few weeks ago.
@rtibbles Could you please check package.json updates that we talked about (browserslist, pinned dependencies)?
Changelog
useKResponsiveWindow
from/lib
to/lib/composables
useKResponsiveWindow
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
fromimport useKResponsiveWindow from 'kolibri-design-system/lib/composables/useKResponsiveWindow';
KResponsiveWindow's
mixin documentation page in favor of a newuseKResponsiveWindow
pageKResponsiveWindow
/lib/composables
and indicate that they are private by_
prefix in their filename. dev docs updates.Steps to test
Testing checklist
Reviewer guidance
After review
CHANGELOG.md