Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address KModal and KSelect rebrand issues #616

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

LianaHarris360
Copy link
Member

@LianaHarris360 LianaHarris360 commented Apr 12, 2024

Description

Addresses issues found in the Kolibri theme token and rebrand updates PR. This pr updates KModal to run updateContentSectionStyle() when mounted, adds padding to KSelect, and fixes minor textbox styling issues.

Issue addressed

Addresses Issues in Google Doc folder here

Before/after screenshots

KModal Before:

kmodalincorrect.mp4

KModal After:

kmodalcorrect.mp4

KSelect Before:
coach-plan-lesson

KSelect After:
Screenshot 2024-04-12 at 11 35 21 AM

Changelog

  • 616
    • Description: Updates KModal to run updateContentSectionStyle() when mounted and adds padding to KSelect
    • Products impact: updated API
    • Addresses: Link(s) to GH issue(s) addressed. Include KDS links as well as links to related issues in a consumer product repository too.
    • Components: KModal, KSelect
    • Breaking: no
    • Impacts a11y: no
    • Guidance: -

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are all UI components LTR and RTL compliant (if applicable)?

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @LianaHarris360, all is looking good to me. I will go ahead and update the changelog file so I can merge in the preparation for the new release.

@MisRob
Copy link
Member

MisRob commented Apr 15, 2024

@LianaHarris360 I tweaked the phrasing of changes in the changelog - removed detail and shifted a bit more on impact, it will help with the release notes creation.

@MisRob MisRob merged commit fc33a04 into learningequality:release-v4 Apr 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants