Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSelect: add event documentation #648

Merged

Conversation

nucleogenesis
Copy link
Member

@nucleogenesis nucleogenesis commented May 31, 2024

Description

I got stuck on an issue in Kolibri by not realizing that @change will trigger anytime the value / v-model changes, even if done externally. @select on the other hand does what I wanted... which was only react to the user actually selecting something. This guidance may have helped me :)

Changelog

  • [KSelect: add event documentation #648]
    • Description: Updates KSelect to include guiding documentation for the events it emits
    • Products impact: none
    • Addresses: n/a
    • Components: KSelect
    • Breaking: no
    • Impacts a11y: no
    • Guidance: See docs

[#648]: PR link

Steps to test

See the docs page for KSelect

I got stuck not realizing that `@change` will trigger anytime
the value / v-model changes, even if done externally. `@select`
on the other hand does what I wanted... which was only react to
the user actually selecting something. This guidance may have
helped me :)
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @nucleogenesis, I am pretty sure this will help more of us :)

@MisRob MisRob self-assigned this Jun 7, 2024
@AlexVelezLl AlexVelezLl merged commit d512c54 into learningequality:release-v4 Jun 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants