You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, recent updates have added additional lines to this PID file, meaning that it is now reading the wrong information.
Instead, we should update the code to only read the second line of the PID file to get the port.
Ideally, in future, we would use Kolibri's utils to determine this information, rather than introspecting the pid file - this will make it less brittle to future changes. But this fix will do for now.
The text was updated successfully, but these errors were encountered:
Currently the code to get the active port from the Kolibri PID file assumes that it can keep reading the file until the file finishes:
kolibri-installer-windows/src/gui-source/Kolibri/Kolibri.cpp
Line 76 in a55fb87
However, recent updates have added additional lines to this PID file, meaning that it is now reading the wrong information.
Instead, we should update the code to only read the second line of the PID file to get the port.
Ideally, in future, we would use Kolibri's utils to determine this information, rather than introspecting the pid file - this will make it less brittle to future changes. But this fix will do for now.
The text was updated successfully, but these errors were encountered: