Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more fields to the user creation and add roles if they are provided #5

Merged
merged 5 commits into from Jul 13, 2020

Conversation

jredrejo
Copy link
Member

@jredrejo jredrejo commented Feb 28, 2020

When OIDC client plugin is used in Kolibri, the very first time an user logins using an OIDC provider will trigger the creation of this user in the Kolibri database. With this plugin:

  • More fields: email, birthdate and gender will be added to the user info in the database
  • If a roles list is provided, the user will be added to these roles.

Closes: #3

Copy link
Contributor

@indirectlylit indirectlylit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Main feedback is that the fields provided don't map perfectly to our internal models. For example birthday vs year, first/last vs full name, no support for email. This mapping would need to be defined and documented

kolibri_oidc_client_plugin/auth.py Outdated Show resolved Hide resolved
kolibri_oidc_client_plugin/auth.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jredrejo jredrejo force-pushed the add_roles_when_creating_user branch from 6ff736b to cd81e86 Compare July 9, 2020 19:10
@indirectlylit indirectlylit merged commit 7c1d8a7 into master Jul 13, 2020
@rtibbles rtibbles deleted the add_roles_when_creating_user branch October 31, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request for role integration with OpenID Connect
2 participants