Add warnings when trying to modify plugins after registry is loaded.

kolibri/plugins/registry.py

@@ -50,6 +50,9 @@
 logger = logging.getLogger(__name__)
 
 
+__initialized = False
+
+
 class PluginExistsInApp(Exception):
     """
     This exception is raise when a plugin is initialized inside a Django app and
@@ -163,6 +166,7 @@ def __initialize():
     """
     Called once to register hook callbacks.
     """
+    global __initialized
     registry = Registry()
     logger.debug("Loading kolibri plugin registry...")
     was_configured = settings.configured
@@ -171,7 +175,12 @@ def __initialize():
             "Django settings already configured when plugin registry initialized"
         )
     registry.register_plugins(config.ACTIVE_PLUGINS)
+    __initialized = True
     return registry
 
 
 registered_plugins = SimpleLazyObject(__initialize)
+
+
+def is_initialized():
+    return __initialized

kolibri/plugins/utils/__init__.py

@@ -392,6 +392,11 @@ def autoremove_unavailable_plugins():
     configured by the user or some other kind of hard dependency that should
     make execution stop if not loadable.
     """
+    from kolibri.plugins.registry import is_initialized
+
+    if is_initialized():
+        # TODO: Turn this into a Runtime error
+        logger.warning("Attempted to updated plugins when registry is initialized")
     changed = False
     # Iterate over a copy of the set so that it is not modified during the loop
     for module_path in config["INSTALLED_PLUGINS"].copy():
@@ -415,6 +420,11 @@ def enable_new_default_plugins():
     default plugins that have been explicitly disabled by a user,
     in versions prior to the implementation of a plugin blacklist.
     """
+    from kolibri.plugins.registry import is_initialized
+
+    if is_initialized():
+        # TODO: Turn this into a Runtime error
+        logger.warning("Attempted to updated plugins when registry is initialized")
     changed = False
     for module_path in DEFAULT_PLUGINS:
         if module_path not in config["INSTALLED_PLUGINS"]: