Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all existing references to session getters and state to the useUser composable #12203

Closed
Tracked by #12204 ...
rtibbles opened this issue May 23, 2024 · 3 comments
Closed
Tracked by #12204 ...
Assignees
Labels
DEV: frontend help wanted Open source contributors welcome TAG: tech update / debt Change not visible to user

Comments

@rtibbles
Copy link
Member

rtibbles commented May 23, 2024

The useUser composable now encapsulates all the vuex getters and state for the session, we should migrate all references to these to instead import the useUser composable and read from there.

See the composable for the full list of getters and state that will need to be remapped: https://github.com/learningequality/kolibri/blob/develop/kolibri/core/assets/src/composables/useUser.js#L36

Note, this will not involve removing the session vuex module.

@nathanaelg16
Copy link
Contributor

Hi @rtibbles, can I try this issue?

@rtibbles
Copy link
Member Author

Hi @nathanaelg16 - yes, please do!

When you make a pull request, I'd suggest making a commit 'per plugin' (learn, coach, etc. and one for the core references).

@rtibbles
Copy link
Member Author

Fixed in #12438 and #12611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend help wanted Open source contributors welcome TAG: tech update / debt Change not visible to user
Projects
None yet
Development

No branches or pull requests

2 participants