Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable explicit disabling of default plugins #2019

Closed
rtibbles opened this issue Aug 24, 2017 · 4 comments
Closed

Enable explicit disabling of default plugins #2019

rtibbles opened this issue Aug 24, 2017 · 4 comments
Labels
TAG: new feature New user-facing feature

Comments

@rtibbles
Copy link
Member

rtibbles commented Aug 24, 2017 •
edited by indirectlylit

Summary

In latest changes in #2013, we re-enable default plugins at a version change.

This could be annoying for users who have explicitly disabled a plugin for a reason, so it would be helpful to explicitly blacklist a default plugin to protect against this behaviour.

Additionally, as suggested in #17 let's migrate from json to ini
@rtibbles rtibbles added this to the 0.7.0 milestone Aug 24, 2017
@rtibbles rtibbles mentioned this issue Aug 24, 2017
Merged
@indirectlylit indirectlylit removed this from the 0.7.0 milestone Oct 27, 2017
@indirectlylit indirectlylit added TODO: needs gherkin update Add to our manual integration tests TAG: new feature New user-facing feature labels Oct 27, 2017
@indirectlylit indirectlylit mentioned this issue Dec 15, 2017
Closed
@indirectlylit
Copy link
Contributor

related conversations in #2510 and #2626

@indirectlylit indirectlylit added this to the 0.8.0 milestone Dec 15, 2017
@indirectlylit indirectlylit added the P0 - critical Priority: Release blocker or regression label Dec 15, 2017
This was referenced Dec 23, 2017
Closed
Closed
@rtibbles
Copy link
Member Author

rtibbles commented Feb 8, 2018

Not sure this is critical, as the default plugin list for custom builds will be set specifically for those custom builds.

@indirectlylit indirectlylit added P2 - normal Priority: Nice to have and removed P0 - critical Priority: Release blocker or regression labels Feb 8, 2018
@indirectlylit
Copy link
Contributor

I don't remember why I set it to critical.

@indirectlylit indirectlylit removed the P2 - normal Priority: Nice to have label Feb 22, 2018
@indirectlylit indirectlylit removed this from the 0.8.0 milestone Feb 22, 2018
@indirectlylit
Copy link
Contributor

fixed in #5637

@radinamatic radinamatic removed the TODO: needs gherkin update Add to our manual integration tests label Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TAG: new feature New user-facing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@benjaoming @radinamatic @rtibbles @indirectlylit