Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove crossComponentTranslator in FacilitiesTasksPage #7086

Closed
nucleogenesis opened this issue Jun 18, 2020 · 0 comments
Closed

Remove crossComponentTranslator in FacilitiesTasksPage #7086

nucleogenesis opened this issue Jun 18, 2020 · 0 comments
Assignees
@nucleogenesis
Labels
TAG: tech update / debt Change not visible to user
Milestone
0.15.0

Comments

@nucleogenesis
Copy link
Member

Observed behavior

Use of crossComponentTranslator to get strings in FacilityTasksPage after string freeze.

Expected behavior

Define strings in the component they're used in or decide if the used strings should be in a core file.

User-facing consequences

None but early on in my time at LE I eradicated crossComponentTranslator usage across the app and I will not continue to suffer its existence when we enter our next round of translations.
@nucleogenesis nucleogenesis added this to the upcoming major milestone Jun 18, 2020
@nucleogenesis nucleogenesis self-assigned this Jun 18, 2020
@jonboiser jonboiser modified the milestones: upcoming major, 0.15.0 Sep 8, 2020
@jonboiser jonboiser mentioned this issue Oct 8, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nucleogenesis nucleogenesis

Labels
TAG: tech update / debt Change not visible to user
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
2 participants
@nucleogenesis @jonboiser