Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove i18n tech debt from 0.14 #7550

Merged
merged 5 commits into from Oct 8, 2020

Conversation

jonboiser
Copy link
Contributor

@jonboiser jonboiser commented Oct 8, 2020

Summary

  1. This removes every current usage of crossComponentTranslator by either moving messages around or into new or existing common[Plugin]strings mixins (new ones were made for "User" and "Device" plugins).

Reviewer guidance

Ideally, try to find each of these messages in the actual app and make sure they are shown correctly (in English, since the messages have new namespaces).

If that's too much, the refactor is pretty mechanical, so just check for typos or things like that.

References

Fixes #7086

Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

// Content activity
notStartedLabel: {
message: 'Not started',
context: 'For content that has not been viewed or engaged with yet',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is context and not the user string, but still remembering that we should steer away from the term content 🙂

Maybe Used to indicate a resource that learners did not yet open and engage with?

Copy link
Contributor Author

@jonboiser jonboiser Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "resource" the most generic term? I would probably even pick something more generic than "content" because "Not started" is a status for things like Exams and Lessons. This string was extracted as a status indicator for an Exam and I think I just wanted to give it a generic category as a common string.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the coach tools we actually have distinct labels for each type to ensure that the gender agreement is correct. For example:

Lesson not started:

labelShort: '{count, plural, other {Not started}}',

Exercise not started:

labelShort: '{count, plural, other {Not started}}',

Also for:

  • Question
  • Quiz
  • Resource

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jonboiser

@jonboiser jonboiser merged commit 0348f40 into learningequality:develop Oct 8, 2020
@jonboiser jonboiser deleted the 0.15-i18n-prep branch October 8, 2020 21:26
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants