New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove i18n tech debt from 0.14 #7550
Conversation
c7d5573
to
0e0b89f
Compare
0e0b89f
to
427f416
Compare
Codecov Report
|
// Content activity | ||
notStartedLabel: { | ||
message: 'Not started', | ||
context: 'For content that has not been viewed or engaged with yet', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is context and not the user string, but still remembering that we should steer away from the term content
🙂
Maybe Used to indicate a resource that learners did not yet open and engage with
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "resource" the most generic term? I would probably even pick something more generic than "content" because "Not started" is a status for things like Exams and Lessons. This string was extracted as a status indicator for an Exam and I think I just wanted to give it a generic category as a common string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the coach tools we actually have distinct labels for each type to ensure that the gender agreement is correct. For example:
Lesson not started:
labelShort: '{count, plural, other {Not started}}', |
Exercise not started:
labelShort: '{count, plural, other {Not started}}', |
Also for:
- Question
- Quiz
- Resource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @jonboiser
Summary
crossComponentTranslator
by either moving messages around or into new or existingcommon[Plugin]strings
mixins (new ones were made for "User" and "Device" plugins).Reviewer guidance
Ideally, try to find each of these messages in the actual app and make sure they are shown correctly (in English, since the messages have new namespaces).
If that's too much, the refactor is pretty mechanical, so just check for typos or things like that.
References
Fixes #7086
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarn
andpip
)