Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign In Page Improvements Needed (Follow up to #7306) #7321

Closed
nucleogenesis opened this issue Jul 16, 2020 · 3 comments
Closed

Sign In Page Improvements Needed (Follow up to #7306) #7321

nucleogenesis opened this issue Jul 16, 2020 · 3 comments
Assignees
@nucleogenesis
Labels
APP: User Re: User app (sign-in, sign-up, user profile, etc.) P1 - important Priority: High impact on UX TAG: tech update / debt Change not visible to user

Comments

@nucleogenesis
Copy link
Member

nucleogenesis commented Jul 16, 2020 •
edited

Observed behavior

This issue is to track and manage the fact that I am intentionally leaving some things for post-release in the Sign In refactor done on #7306

Expected behavior

Better code so the next person who dives into the SignIn part of user has less mental overhead.

User-facing consequences

None.
@nucleogenesis nucleogenesis added the TAG: tech update / debt Change not visible to user label Jul 16, 2020
@nucleogenesis nucleogenesis added this to the upcoming patch milestone Jul 16, 2020
@nucleogenesis nucleogenesis self-assigned this Jul 16, 2020
@jredrejo
Copy link
Member

I'd love to study the pertinence of using xstate to manage the sign in procedures after the release

@jonboiser jonboiser added this to To do in 0.15 prerequisites Oct 12, 2020
@jonboiser jonboiser removed this from To do in 0.15 prerequisites Oct 12, 2020
@jonboiser jonboiser added the APP: User Re: User app (sign-in, sign-up, user profile, etc.) label Feb 20, 2021
@jonboiser jonboiser modified the milestones: upcoming patch, 0.14.7, 0.15.0 Mar 9, 2021
@jonboiser jonboiser mentioned this issue Mar 9, 2021
Merged
9 tasks
@nucleogenesis nucleogenesis added the P1 - important Priority: High impact on UX label Mar 16, 2021
@nucleogenesis nucleogenesis self-assigned this May 11, 2021
@rtibbles rtibbles removed this from the 0.15.0 milestone Nov 22, 2021
@nucleogenesis
Copy link
Member Author

The remaining concerns for this issue were kind of indirectly addressed by @indirectlylit in #8443 - will close this as I don't think SignInPage is in bad shape at this point.

@rtibbles
Copy link
Member

rtibbles commented Dec 6, 2021

indirectly addressed by @indirectlylit

This seems oddly appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nucleogenesis nucleogenesis

Labels
APP: User Re: User app (sign-in, sign-up, user profile, etc.) P1 - important Priority: High impact on UX TAG: tech update / debt Change not visible to user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jredrejo @rtibbles @nucleogenesis @jonboiser