split user plugin #8443
Merged
split user plugin #8443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indirectlylit
force-pushed
the
split-user-plugin
branch
from
62a59a3
to
0c1bc9b
Compare
indirectlylit
force-pushed
the
split-user-plugin
branch
2 times, most recently
from
0b7f145
to
9ca986a
Compare
indirectlylit
force-pushed
the
split-user-plugin
branch
7 times, most recently
from
fe74ae9
to
41996ec
Compare
rtibbles
reviewed
Oct 8, 2021
| @@ -1,5 +1,6 @@ | |||
| <template> | |||
There was a problem hiding this comment.
Does this need to be put into the core API? It seems like boiler plate.
There was a problem hiding this comment.
Indeed, it is in the core API!
It's a step in the direction of this: #5719
Once 0.15 is cut, I'll apply the pattern to user_auth also
kolibri/plugins/user_profile/assets/src/views/commonUserStrings.js
Outdated
Show resolved
Hide resolved
kolibri/plugins/user_profile/assets/src/views/getUrlParameter.js
Outdated
Show resolved
Hide resolved
|
Hi @indirectlylit I was asked by @radinamatic to test this PR and I'm happy to report that all main workflows are functioning correctly. |
indirectlylit
force-pushed
the
split-user-plugin
branch
3 times, most recently
from
9ab4b5e
to
0b95c17
Compare
indirectlylit
force-pushed
the
split-user-plugin
branch
from
0b95c17
to
5bb007d
Compare
indirectlylit
force-pushed
the
split-user-plugin
branch
from
5bb007d
to
60ea07a
Compare
rtibbles
approved these changes
Oct 12, 2021
indirectlylit
added
P2 - normal
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
userapp plugin into two plugins:user_authanduser_profile/setupPageRootcore component and begins migration to that (more post-0.15) - ref refactor User Auth, Learn, Device, and Facility apps to use new Coach-style page indexes #5719