Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a reusable 'New' badge component #7386

Closed
indirectlylit opened this issue Jul 24, 2020 · 2 comments
Closed

create a reusable 'New' badge component #7386

indirectlylit opened this issue Jul 24, 2020 · 2 comments
Labels
P2 - normal Priority: Nice to have TAG: tech update / debt Change not visible to user TAG: user strings Application text that gets translated
Projects
0.15 prerequisites
Milestone
upcoming major

Comments

@indirectlylit
Copy link
Contributor

Observed behavior

as of #7368 the 'New' label is used in 3 places, with duplicated styling and strings:

image

Expected behavior

badge should be be a re-usable core component

Context

0.14.0
@indirectlylit indirectlylit added DEV: frontend P2 - normal Priority: Nice to have TAG: tech update / debt Change not visible to user labels Jul 24, 2020
@indirectlylit indirectlylit added the TAG: user strings Application text that gets translated label Jul 24, 2020
@jonboiser jonboiser added this to To do in 0.15 prerequisites Oct 12, 2020
@YashJipkate YashJipkate mentioned this issue Mar 16, 2021
Merged
9 tasks
@YashJipkate
Copy link
Contributor

Hi @indirectlylit @jonboiser I want to work on this and have made a PR regarding this. Please take a look.
Thanks!

@indirectlylit
Copy link
Contributor Author

thanks @YashJipkate!

0.15 prerequisites automation moved this from To do to Done Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 - normal Priority: Nice to have TAG: tech update / debt Change not visible to user TAG: user strings Application text that gets translated
Projects
No open projects
0.15 prerequisites
Done
Milestone
upcoming major
Development

No branches or pull requests
2 participants
@indirectlylit @YashJipkate