Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update notification styling #7368

Merged
merged 4 commits into from
Jul 23, 2020

Conversation

indirectlylit
Copy link
Contributor

@indirectlylit indirectlylit commented Jul 23, 2020

Summary

before after
image image

Reviewer guidance

make sense?

any regressions?


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@indirectlylit indirectlylit added the TODO: needs review Waiting for review label Jul 23, 2020
@indirectlylit indirectlylit added this to the 0.14.0 milestone Jul 23, 2020
@jonboiser jonboiser linked an issue Jul 23, 2020 that may be closed by this pull request
@radinamatic
Copy link
Member

I actually liked the old version of the notification, it was impossible to miss.

This new one is better styled, true, but so easy to overlook 😕

@jonboiser
Copy link
Contributor

This test needs to be fixed here: https://travis-ci.org/github/learningequality/kolibri/jobs/711165802#L8356

It might simply just involve flipping the indices of the paragraphs to get the right text.

@khangmach khangmach requested a review from jonboiser July 23, 2020 17:40
@jonboiser jonboiser self-assigned this Jul 23, 2020
@indirectlylit
Copy link
Contributor Author

this better?

image

@radinamatic
Copy link
Member

Yes, this does look more prominent 👍

We could discuss adding a different background color for that block (like for old notifications), to make it pop out even more, but this looks OK for now.

@indirectlylit
Copy link
Contributor Author

fixed linting, force-merging

@indirectlylit indirectlylit merged commit 6b86606 into learningequality:release-v0.14.x Jul 23, 2020
@indirectlylit indirectlylit deleted the update branch July 27, 2020 17:44
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

padding needed above 'new version' banner
3 participants