Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filters in lesson management have layout regressions #7437

Closed
indirectlylit opened this issue Aug 4, 2020 · 3 comments · Fixed by #7438
Closed

filters in lesson management have layout regressions #7437

indirectlylit opened this issue Aug 4, 2020 · 3 comments · Fixed by #7438
Labels
P0 - critical Priority: Release blocker or regression TAG: regression Something that previously worked
Milestone
0.14.0

Comments

@indirectlylit
Copy link
Contributor

indirectlylit commented Aug 4, 2020 •
edited

Observed behavior

image

image

Context

0.14.0 beta 14
@indirectlylit indirectlylit added DEV: frontend P0 - critical Priority: Release blocker or regression TAG: regression Something that previously worked labels Aug 4, 2020
@indirectlylit indirectlylit added this to the 0.14.0 milestone Aug 4, 2020
@indirectlylit indirectlylit changed the title filter box in lesson management has layout regression filters in lesson management have layout regressions Aug 4, 2020
@jonboiser
Copy link
Contributor

I'm not seeing the overflow with the magnifier class icon inside the SearchBox.

As for the KIcons next to the UiSelects, it should be enough to add 16px margin-bottom to match the margins of the UiSelect itself.

image

@indirectlylit
Copy link
Contributor Author

will do

@jonboiser
Copy link
Contributor

Things don't overflow for me in Chrome, but it does seem the sub-components of the searchbar are a little "cramped". The text input and "X (clear)" button actually overlap a little.

image

indirectlylit added a commit to indirectlylit/kolibri that referenced this issue Aug 4, 2020
@indirectlylit
fixes learningequality#7437
4135506
indirectlylit added a commit to indirectlylit/kolibri that referenced this issue Aug 4, 2020
@indirectlylit
fixes learningequality#7437
0b7d5ae
@indirectlylit indirectlylit mentioned this issue Aug 4, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P0 - critical Priority: Release blocker or regression TAG: regression Something that previously worked
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

coach layout updates indirectlylit/kolibri
2 participants
@indirectlylit @jonboiser