Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The search icon is duplicated in the ePUB viewer after enabling the search feature #7627

Closed
ghost opened this issue Oct 27, 2020 · 0 comments · Fixed by #7631
Closed

The search icon is duplicated in the ePUB viewer after enabling the search feature #7627

ghost opened this issue Oct 27, 2020 · 0 comments · Fixed by #7631
Assignees
@jonboiser
Labels
bug Behavior is wrong or broken P2 - normal Priority: Nice to have
Milestone
0.14.5

Comments

@ghost
Copy link

ghost commented Oct 27, 2020 •
edited by jonboiser

Actual result:

The search icon is duplicated in the ePUB viewer after enabling the search feature

Expected result:

The search icon shouldn't be duplicated in the ePUB viewer after enabling the search feature

Steps to reproduce:

  1. Given I am signed in to Kolibri
  2. Open ePUB file from the Kolibri QA channel
  3. Click on the search icon
  4. Pay attention to the search icon which is duplicated

Video:

http://e.pc.cd/VYbotalK

image

Context:

Kolibri version: 0.14.3
Device: Raspberry Pi 3B+
OS: tested on Mac mini (Mid 2011) macOS Sierra v 10.12.6
Browser: Google Chrome latest
@jonboiser jonboiser added bug Behavior is wrong or broken P2 - normal Priority: Nice to have labels Oct 27, 2020
@jonboiser jonboiser added this to the 0.14.4 milestone Oct 27, 2020
jonboiser added a commit to jonboiser/kolibri that referenced this issue Oct 27, 2020
@jonboiser
Prevent SearchButton components from overlapping in EPUB Renderer
fdf3077 
Fixes learningequality#7627
@jonboiser jonboiser self-assigned this Oct 27, 2020
@jonboiser jonboiser mentioned this issue Oct 27, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonboiser jonboiser

Labels
bug Behavior is wrong or broken P2 - normal Priority: Nice to have
Projects
None yet
Milestone
0.14.5
Development

Successfully merging a pull request may close this issue.

Prevent SearchButton components from overlapping in EPUB Renderer jonboiser/kolibri
1 participant
@jonboiser